Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sweep GHA Fix] Update pnpm install command to fix failing GitHub Actions #279

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sweep-ai[bot]
Copy link

@sweep-ai sweep-ai bot commented Jan 30, 2024

PR Feedback (click)

  • 👍 Sweep Did Well
  • 👎 Sweep Needs Improvement
    I created this PR to fix the failing GitHub Actions.## Description
    This PR updates the pnpm install command in the Dockerfile and WorkflowRunner.ts files to fix the failing GitHub Actions run. The previous command pnpm install --frozen-lockfile was causing an error due to the pnpm-lock.yaml file not being up to date with the packages/cli/package.json file. The updated command pnpm install --no-frozen-lockfile ensures that the pnpm-lock.yaml file is not treated as frozen and will be updated during the installation process.

Summary of Changes

  • Modified the Dockerfile in the docker/images/n8n-custom directory to update the pnpm install command.
  • Modified the WorkflowRunner.ts file in the packages/cli/src directory to update the pnpm install command.

Copy link
Author

sweep-ai bot commented Jan 30, 2024

Rollback Files For Sweep

  • Rollback changes to docker/images/n8n-custom/Dockerfile
  • Rollback changes to docker/images/n8n-custom/Dockerfile
  • Rollback changes to packages/cli/src/WorkflowRunner.ts
  • Rollback changes to packages/cli/src/WorkflowRunner.ts

@sweep-ai sweep-ai bot added the sweep Assigns Sweep to an issue or pull request. label Jan 30, 2024
Copy link

height bot commented Jan 30, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sweep Assigns Sweep to an issue or pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant