New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make implicit double promotion/casting explicit (fixes #228) #273

Merged

recp merged 1 commit into recp:master from JulianSchoenbaechler:fix-Wdouble-promotion

Dec 31, 2022

Contributor

JulianSchoenbaechler commented Dec 29, 2022 •

edited

Loading

This fixes issue #228. Clang, as well as gcc will warn about implicit double conversions if cglm is compiled with -Wdouble-promotion.

Double promotion happens for:

Comparisons (< > <= >= ==) with floats and the defined doubles GLM_FLT_EPSILON and CGLM_PRINT_MAX_TO_SHORT. So I explicitly used the f indicating that the values should be treated as floats.
The argument list of all the IO printf() functions when floats are displayed. Added an explicit cast for suppressing the warning.


          Make double promotion in printf args explicit

bfd87ac

Also use f-suffix on epsilon definitions for float comparisons.

recp merged commit 3877159 into recp:master

Owner

recp commented Dec 31, 2022

Hi @JulianSchoenbaechler,

Many thanks for your contributions, the PR is merged 🚀

recp mentioned this pull request

Clang warnings for implicit conversions from float to double #228

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet