mat2: add new function glm_mat2_make #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function takes in a 4 element float array and converts it into a mat2 matrix. Signed-off-by: Vincent Davis Jr <vince@underview.tech>
recp
reviewed
May 15, 2023
| CGLM_INLINE | ||
| mat2s | ||
| glms_mat2_(make)(float * __restrict src, mat2s dest) { | ||
| glm_mat2_make(src, dest.raw); |
There was a problem hiding this comment.
actually the returned value is dest os no need to separate dest param, I'll fix it after merge.
|
@EasyIP2023 thanks for your contribution[s], the PR is merged now 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function takes in a 4 element float array
and converts it into a mat2 matrix.