Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eqv, eq, fill for ivec2 and ivec3, new print functions for ivec2 and ivec4, documentation fixes #346

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

duarm
Copy link
Contributor

@duarm duarm commented Sep 4, 2023

  • New glm_ivec4_print, glm_ivec2_print functions
  • New eqv, eq, fill functions for ivec3 and ivec2
  • Adding missing glm_vec2_print to the docs.
  • Adding missing call func glmc_vec2_fill, glmc_vec2_eq, glmc_vec2_eqv
  • Changed wording on the print documention to a generic "vector" and "matrix" instead of the type, to be more inline with how it's worded everywhere else.

@recp recp merged commit e0e7e38 into recp:master Sep 5, 2023
@recp
Copy link
Owner

recp commented Sep 5, 2023

@duarm the PR is merged, thanks for your contributions 🚀 It would be nice to have ivec4 versions of the new functions :)

@gottfriedleibniz
Copy link

Would it be possible to update glm_ivec2_fill and glm_ivec3_fill to explicitly cast those values? For example, compiling with MSVC /W2 (or above) will throw:

cglm\include\cglm\ivec2.h(219,17): warning C4244: '=': conversion from 'float' to 'int', possible loss of data 
cglm\include\cglm\ivec3.h(227,24): warning C4244: '=': conversion from 'float' to 'int', possible loss of data 

@recp
Copy link
Owner

recp commented Sep 5, 2023

@gottfriedleibniz wow my mistake, those parameters must be int as base type of vector, it is fixed at: 126f809

@gottfriedleibniz
Copy link

If that's the case, glmc_ivec{2,3}_fill also require updating.

@recp
Copy link
Owner

recp commented Sep 5, 2023

done :)

@duarm
Copy link
Contributor Author

duarm commented Sep 5, 2023

missed that too, sorry

@duarm duarm changed the title eqv, eq, fill for ivec2 and ivec3, documentation fixes eqv, eq, fill for ivec2 and ivec3, new print functions for ivec2 and ivec4, documentation fixes Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants