update pybind11 (2.2.4 -> 2.5.0) #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
=======================================
Coverage 75.00% 75.00%
=======================================
Files 12 12
Lines 480 480
=======================================
Hits 360 360
Misses 120 120 Continue to review full report at Codecov.
|
j-i-k-o
changed the title
j-i-k-o
changed the title
j-i-k-o
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
問題報告
こちらの方でpyqubo>=1.0.0 とOpenJij (https://github.com/OpenJij/OpenJij) を同時にimportすると、linuxを使用した時にPythonがsegfaultでクラッシュする問題が起きる事象を確認しました。
原因
この原因はpybind11の旧バージョンに存在するバグであり、pybind11を用いた異なるバージョンのコンパイラでコンパイルされたモジュールを同時にimportするとSTLの互換性が取れないためにクラッシュするというものでした。ですので、OpenJijのみならず、pybind11を用いた他のライブラリと同時にimportしてもこの問題が発生する可能性があります。
関連するissueはこちらにあります。(pybind/pybind11#1262)
解決手法
pybind11>=2.4.0 以降であればこの問題は解決されているため、ビルドに用いるライブラリを2.5.0にすることで解決できると思います。
手元の環境でmanylinux1を用いてwheelを生成してみましたが、問題なく動作することを確認しています。
よろしくおねがいします。