Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore package.json #356

Merged
merged 1 commit into from
May 15, 2024
Merged

chore: ignore package.json #356

merged 1 commit into from
May 15, 2024

Conversation

AkifumiSato
Copy link
Collaborator

@AkifumiSato AkifumiSato commented May 15, 2024

changesetsが行うリリースPRでpackage.jsonを更新しますが、この更新に対するフォーマットルールのオプションがぱっと見見当たりませんでした。
https://github.com/changesets/action
取り急ぎbiomeのルールと競合するので、package.jsonのformatを無視するようにします。

@AkifumiSato AkifumiSato requested a review from koichik May 15, 2024 04:41
Copy link

changeset-bot bot commented May 15, 2024

⚠️ No Changeset found

Latest commit: 9d827db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@koichik
Copy link
Member

koichik commented May 15, 2024

これがそのまんまか
changesets/action#366

Copy link
Member

@koichik koichik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ともあれLGTM!

@AkifumiSato AkifumiSato merged commit 3cb4c3e into main May 15, 2024
2 checks passed
@AkifumiSato AkifumiSato deleted the ignore-packagejson-format branch May 15, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants