fix deprecations (#345)

rectorphp · Sep 2, 2024 · fb26209 · fb26209
1 parent ef84d74
commit fb26209
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/composer.json b/composer.json
@@ -12,6 +12,7 @@
  "doctrine/orm": "^2.19",
  "phpstan/extension-installer": "^1.4",
  "phpstan/phpstan": "^1.11",
+ "phpstan/phpstan-deprecation-rules": "^1.2",
  "phpstan/phpstan-webmozart-assert": "^1.2",
  "phpunit/phpunit": "^10.5",
  "rector/rector-src": "dev-main",

diff --git a/phpstan.neon b/phpstan.neon
@@ -46,3 +46,7 @@ parameters:
  -
  message: '#PHPDoc tag @return contains unresolvable type#'
  path: rules/CodeQuality/Contract/PropertyAttributeTransformerInterface.php
+
+ # needed for instanceof method API
+ - '#Doing instanceof PHPStan\\Type\\ObjectType is error\-prone and deprecated\. Use Type\:\:isObject\(\) or Type\:\:getObjectClassNames\(\) instead#'
+ - '#Doing instanceof PHPStan\\Type\\(Generic\\GenericObjectType|ArrayType) is error\-prone and deprecated#'
diff --git a/src/TypeAnalyzer/CollectionTypeResolver.php b/src/TypeAnalyzer/CollectionTypeResolver.php
@@ -54,7 +54,7 @@ public function resolveFromTypeNode(TypeNode $typeNode, Node $node): ?FullyQuali
  }
 
  if ($typeNode instanceof ArrayTypeNode && $typeNode->type instanceof IdentifierTypeNode) {
- $nameScope = $this->nameScopeFactory->createNameScopeFromNode($node);
+ $nameScope = $this->nameScopeFactory->createNameScopeFromNodeWithoutTemplateTypes($node);
  $fullyQualifiedName = $nameScope->resolveStringName($typeNode->type->name);
  return new FullyQualifiedObjectType($fullyQualifiedName);
  }