Refactor the OrderByKeyToClassConstRector to use the new enum only in Criteria::orderBy method calls

[julienfastre]

Since version 2.2.0 of doctrine/collection, the constant Doctrine\Common\Collections\Criteria is deprecated in favor of new enum \Doctrine\Common\Collections\Order.

But this enum should only be used in invocations of Doctrine\Common\Collection\Criteria::orderBy method call. Other calls (in attributes, or for the same method name on object instantiating another class) should not be changed: the string 'ASC' and 'DESC' should be kept elsewhere.

This PR refactor the rule which, previously, replaced all the 'ASC' and 'DESC' by the Criteria::ASC|DESC.

After this MR:

• all invocation of class constant Criteria::ASC and Criteria::DESC are replaced by, respectively, the string "ASC" ans "DESC";
• in the method invocation Criteria::orderBy, the usage of the "ASC" (lowercase or uppercase), "DESC" (lowercase or uppercase), Criteria::ASC, Criteria::DESC is replaced by the new enum Order::Ascending, Order::Descending;
• the rule is added to the new ruleset for Collection 2.2;

The previous rule, which changed the usage of the string "ASC" (lowercase or uppercase) or "DESC" (lowercase or uppercase) by the usage of Criteria::ASC and Criteria::DESC is, obviously, removed.

Comments and documentation supporting this change

• Introduce Order enum doctrine/collections#389;
• [RFC] Follow-up on doctrine/collections Order enum doctrine/orm#11313 (comment)

Closes #325

EDIT list the changes in a more understandable (?) way.

[julienfastre]

Still some TODO in this PR:

• this rule should not apply on PHP versions earlier that 8.1.0 and doctrine collection greater that 2.2.0
• find a way to ensure that the 'orderBy' method does apply on a \Doctrine\Common\Collections\Criteria instance
• find a way to identify the full FQDN for Criteria

[samsonasik]

$direction need to be transformed to strtoupper first to ensure it always uppercase to compare

[julienfastre]

Actually, this is done on lines 169 and 181.

But this is maybe not the most readable way for doing this...

[samsonasik]

Ok, let's give it a try 👍

[samsonasik]

Thank you @julienfastre

[samsonasik]

php open tag seems cause use statement prefixed in code example, and become:

namespace RectorPrefix202408;
use RectorPrefix202408\Doctrine\Common\Collections\Criteria;

ref rectorphp/rector@b8c4f15#diff-c260cb91d355f253688b74213c5bb7c75414832d6c18ba756b6ba3accf08964f

[samsonasik]

#341

[TomasVotruba]

Thank you @julienfastre 👍

[TomasVotruba]

I wonder, why not add the rule here too?

[samsonasik]

This specifically for doctrine 2.2+