[EarlyReturn] Clena up equal node check on IfAndAnalyzer::isIfStmtExp…

…rUsedInNextReturn() (#5710)
rectorphp · Mar 11, 2024 · 8ade0b9 · 8ade0b9
1 parent 2adeacc
commit 8ade0b9
Showing 1 changed file with 1 addition and 9 deletions.
diff --git a/rules/EarlyReturn/NodeAnalyzer/IfAndAnalyzer.php b/rules/EarlyReturn/NodeAnalyzer/IfAndAnalyzer.php
@@ -40,15 +40,7 @@ public function isIfStmtExprUsedInNextReturn(If_ $if, Return_ $return): bool
         $ifExprs = $this->betterNodeFinder->findInstanceOf($if->stmts, Expr::class);
         return (bool) $this->betterNodeFinder->findFirst(
             $return->expr,
-            function (Node $node) use ($ifExprs): bool {
-                foreach ($ifExprs as $ifExpr) {
-                    if ($this->nodeComparator->areNodesEqual($node, $ifExpr)) {
-                        return true;
-                    }
-                }
-
-                return false;
-            }
+            fn (Node $node): bool => $this->nodeComparator->isNodeEqual($node, $ifExprs)
         );
     }
 }