[DX] Remove complementary interface, as not practical (#4757)

Co-authored-by: GitHub Action <actions@github.com>
rectorphp · Aug 10, 2023 · fe4d90d · fe4d90d
1 parent e0167e6
commit fe4d90d
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 36 deletions.
diff --git a/packages/PostRector/Contract/Rector/ComplementaryRectorInterface.php b/packages/PostRector/Contract/Rector/ComplementaryRectorInterface.php
diff --git a/src/Configuration/ConfigInitializer.php b/src/Configuration/ConfigInitializer.php
@@ -9,7 +9,6 @@
 use Rector\Core\Contract\Rector\RectorInterface;
 use Rector\Core\FileSystem\InitFilePathsResolver;
 use Rector\Core\Php\PhpVersionProvider;
-use Rector\PostRector\Contract\Rector\ComplementaryRectorInterface;
 use Rector\PostRector\Contract\Rector\PostRectorInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
 use Symfony\Component\DependencyInjection\Argument\RewindableGenerator;
@@ -30,11 +29,7 @@ public function __construct(
         private readonly SymfonyStyle $symfonyStyle,
         private readonly PhpVersionProvider $phpVersionProvider,
     ) {
-        if ($rectors instanceof RewindableGenerator) {
-            $this->rectors = iterator_to_array($rectors->getIterator());
-        } else {
-            $this->rectors = $rectors;
-        }
+        $this->rectors = $rectors instanceof RewindableGenerator ? iterator_to_array($rectors->getIterator()) : $rectors;
     }
 
     public function createConfig(string $projectDirectory): void
@@ -77,13 +72,7 @@ private function filterActiveRectors(array $rectors): array
     {
         return array_filter(
             $rectors,
-            static function (RectorInterface $rector): bool {
-                if ($rector instanceof PostRectorInterface) {
-                    return false;
-                }
-
-                return ! $rector instanceof ComplementaryRectorInterface;
-            }
+            static fn(RectorInterface $rector): bool => ! $rector instanceof PostRectorInterface
         );
     }
 

diff --git a/src/Console/Command/ListRulesCommand.php b/src/Console/Command/ListRulesCommand.php
@@ -8,7 +8,6 @@
 use Rector\ChangesReporting\Output\ConsoleOutputFormatter;
 use Rector\Core\Configuration\Option;
 use Rector\Core\Contract\Rector\RectorInterface;
-use Rector\PostRector\Contract\Rector\ComplementaryRectorInterface;
 use Rector\PostRector\Contract\Rector\PostRectorInterface;
 use Rector\Skipper\SkipCriteriaResolver\SkippedClassResolver;
 use Symfony\Component\Console\Command\Command;
@@ -91,13 +90,7 @@ private function resolveRectorClasses(): array
     {
         $customRectors = array_filter(
             $this->rectors,
-            static function (RectorInterface $rector): bool {
-                if ($rector instanceof PostRectorInterface) {
-                    return false;
-                }
-
-                return ! $rector instanceof ComplementaryRectorInterface;
-            }
+            static fn(RectorInterface $rector): bool => ! $rector instanceof PostRectorInterface
         );
 
         $rectorClasses = array_map(static fn (RectorInterface $rector): string => $rector::class, $customRectors);

diff --git a/src/NonPhpFile/Rector/RenameClassNonPhpRector.php b/src/NonPhpFile/Rector/RenameClassNonPhpRector.php
@@ -8,13 +8,12 @@
 use Rector\Core\Configuration\RenamedClassesDataCollector;
 use Rector\Core\Contract\Rector\ConfigurableRectorInterface;
 use Rector\Core\Contract\Rector\NonPhpRectorInterface;
-use Rector\PostRector\Contract\Rector\ComplementaryRectorInterface;
 use Symplify\RuleDocGenerator\Contract\ConfigurableRuleInterface;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 use Webmozart\Assert\Assert;
 
-final class RenameClassNonPhpRector implements NonPhpRectorInterface, ConfigurableRuleInterface, ConfigurableRectorInterface, ComplementaryRectorInterface
+final class RenameClassNonPhpRector implements NonPhpRectorInterface, ConfigurableRuleInterface, ConfigurableRectorInterface
 {
     /**
      * @see https://regex101.com/r/HKUFJD/7