Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate few option constants #2112

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Deprecate few option constants #2112

merged 1 commit into from
Apr 21, 2022

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Apr 20, 2022

See #1703

@TomasVotruba TomasVotruba changed the title tv deprecate options Deprecate few option constants, enable symlinks by default Apr 20, 2022
@sabbelasichon
Copy link
Contributor

@TomasVotruba I would like to keep this option, because in some cases it is convenient to disallow symlinks following. Please don´t remove it.

@TomasVotruba
Copy link
Member Author

I'll get back to it tomorrow. I think we're introducing too much detailed configuration, that can be handled by saint default.

Could you share such cases?

@TomasVotruba TomasVotruba force-pushed the tv-deprecate-options branch 2 times, most recently from 59429e5 to 187fd3f Compare April 20, 2022 21:35
@sabbelasichon
Copy link
Contributor

Before i introduced this option the symlinks were followed per default, but someone was trying to use the . as paths option for a TYPO3 Extension. In TYPO3 those setups are creating recursive symlinks (hard to explain) and using the skip option does not work because the skipper comes in place at a later time.
see also rectorphp/rector#6950

I can totally understand if you don´t like to support it, but for some it is very convenient. I am using an explicit paths configuration instead. I would be fine with it. But if you could make to support it, it would be nice.

@TomasVotruba TomasVotruba changed the title Deprecate few option constants, enable symlinks by default Deprecate few option constants Apr 21, 2022
@TomasVotruba
Copy link
Member Author

I'm merging just the constant depreciations.
The symlinks are in another PR now to keep it separated.

I'm on phone now, but I'll check the examples during day. Thanks :)

@TomasVotruba TomasVotruba merged commit a0c8a6b into main Apr 21, 2022
@TomasVotruba TomasVotruba deleted the tv-deprecate-options branch April 21, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants