Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StaticTypeMapper] Clean up NameNodeMapper check Scalar and class exists #5865

Merged
merged 9 commits into from
May 10, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented May 10, 2024

  • scalar check should check on Identifier, which handled on IdentifierNodeMapper
  • class exists seems not needed, test run test and seems still working ok

@samsonasik samsonasik marked this pull request as draft May 10, 2024 02:25
@samsonasik samsonasik force-pushed the clean-up-name-node-mapper branch from 50f6d73 to 6f28b55 Compare May 10, 2024 03:11
@samsonasik samsonasik marked this pull request as ready for review May 10, 2024 03:11
@samsonasik
Copy link
Member Author

NameNodeMapper seems registered after FullyQualifiedNodeMapper so it should be safe to no need check of it.

private const PHP_PARSER_NODE_MAPPER_CLASSES = [
ExprNodeMapper::class,
FullyQualifiedNodeMapper::class,
IdentifierNodeMapper::class,
IntersectionTypeNodeMapper::class,
NameNodeMapper::class,

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 48fc55d into main May 10, 2024
42 checks passed
@samsonasik samsonasik deleted the clean-up-name-node-mapper branch May 10, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants