[TypeDeclaratoin] Skip type if changed (#6261)

rules-tests/TypeDeclaration/Rector/Param/ParamTypeFromStrictTypedPropertyRector/Fixture/changed_after_assign_type.php.inc

@@ -0,0 +1,39 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\Param\ParamTypeFromStrictTypedPropertyRector\Fixture;
+
+final class ChangedAfterAssignType
+{
+    private array $kind;
+
+    public function setAge($kind)
+    {
+        $this->kind = $kind;
+
+        if (!is_array($kind)) {
+            $kind = [$kind];
+        }
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\Param\ParamTypeFromStrictTypedPropertyRector\Fixture;
+
+final class ChangedAfterAssignType
+{
+    private array $kind;
+
+    public function setAge(array $kind)
+    {
+        $this->kind = $kind;
+
+        if (!is_array($kind)) {
+            $kind = [$kind];
+        }
+    }
+}
+
+?>

rules-tests/TypeDeclaration/Rector/Param/ParamTypeFromStrictTypedPropertyRector/Fixture/skip_changed_type.php.inc

@@ -0,0 +1,17 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\Param\ParamTypeFromStrictTypedPropertyRector\Fixture;
+
+final class SkipChangedType
+{
+    private array $kind;
+
+    public function setAge($kind)
+    {
+        if (!is_array($kind)) {
+            $kind = [$kind];
+        }
+
+        $this->kind = $kind;
+    }
+}

rules/TypeDeclaration/Rector/Param/ParamTypeFromStrictTypedPropertyRector.php

@@ -12,6 +12,7 @@
 use PhpParser\Node\Param;
 use PhpParser\Node\Stmt\Property;
 use PhpParser\Node\UnionType;
+use PHPStan\Analyser\Scope;
 use PHPStan\Type\Type;
 use Rector\Core\Rector\AbstractRector;
 use Rector\Core\ValueObject\PhpVersionFeature;
@@ -99,6 +100,11 @@ public function decorateParamWithType(FunctionLike $functionLike, Param $param):
             return null;
         }
 
+        $scope = $param->getAttribute(AttributeKey::SCOPE);
+
+        $paramName = $this->getName($param);
+        $originalParamType = $scope->getVariableType($paramName);
+
         /** @var Assign[] $assigns */
         $assigns = $this->betterNodeFinder->findInstanceOf((array) $functionLike->getStmts(), Assign::class);
         foreach ($assigns as $assign) {
@@ -110,6 +116,10 @@ public function decorateParamWithType(FunctionLike $functionLike, Param $param):
                 continue;
             }
 
+            if ($this->hasTypeChangedBeforeAssign($assign, $paramName, $originalParamType)) {
+                return null;
+            }
+
             $singlePropertyTypeNode = $this->matchPropertySingleTypeNode($assign->var);
             if (! $singlePropertyTypeNode instanceof Node) {
                 return null;
@@ -157,4 +167,14 @@ private function matchPropertySingleTypeNode(PropertyFetch $propertyFetch): ?Nod
 
         return $typeNode;
     }
+
+    private function hasTypeChangedBeforeAssign(Assign $assign, string $paramName, Type $originalType): bool
+    {
+        $scope = $assign->getAttribute(AttributeKey::SCOPE);
+        if (! $scope instanceof Scope) {
+            return false;
+        }
+        $currentParamType = $scope->getVariableType($paramName);
+        return ! $currentParamType->equals($originalType);
+    }
 }