Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP 8.0] Doc annotations to php attributes #3210

Closed
TomasVotruba opened this issue Apr 21, 2020 · 4 comments
Closed

[PHP 8.0] Doc annotations to php attributes #3210

TomasVotruba opened this issue Apr 21, 2020 · 4 comments

Comments

@TomasVotruba
Copy link
Member

TomasVotruba commented Apr 21, 2020 •
edited
Loading

image

Now we have to do it 😆
@TomasVotruba
Copy link
Member Author

Covered in #3254

@TomasVotruba
Copy link
Member Author

https://twitter.com/VotrubaT/status/1255264005771481096

@mrcodefinger
Copy link

Hi @TomasVotruba!
Is there a way to set @noRector as an attribute now?
bin/rector rectify --future/attributes.php gives me an

Command "rectify" is not defined.

error.

Greetz
Gabriel

@TomasVotruba
Copy link
Member Author

Hi, the attribute is not yet supported.

The rectify command was removed few years ago :) use process instead.

TomasVotruba added a commit that referenced this issue Dec 17, 2022
@TomasVotruba
Updated Rector to commit 7d5d1ce55264aec6d17b3c7013802103c813c0a3
baf8af4 
rectorphp/rector-src@7d5d1ce [Core] Performance improvement: Remove unnecessary re-call FileFactory::createFileInfosFromPaths() (#3210)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TomasVotruba @mrcodefinger