-
-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We need your help with testing Rector 0.9 #4913
Comments
On
Which is already logged here: #4406 I am indeed testing on a Laravel project. Will report more as I go through testing all the rule sets. |
I have problems with apps where symfony 4.2 packages (especially symfony/config I think) are used as dependencies so I am waiting for prefixed version to test it |
Great work! I'll take a closer look later on, but here are some things I've found so far:
Rector wants to move the first line to the second, but that breaks And I get an |
Thanks @samsonasik! The only problem I have is a Segmentation fault on one method. I'll try to create a reproducible example. |
This appears to be fixed on |
@stephanvierkant Hi, thank you for looking into this. |
Good news! 🥳 The prefixed version is now passing on simple tests: Could you give it more propper 💪 battle testing? |
It's out now! 👏 Thank you for testing and feedback ❤️ https://getrector.org/blog/2020/12/28/rector-09-released (For any further issues, please make a new ones.) |
Thanks for this new version! I really like the new config. The Segmentation fault magically disappeared. |
rectorphp/rector-src@8c5cfaf FamilyRelationsAnalyzer: final classes can't have children (#4913)
We're working hard last month on next release of Rector - 0.9.
First we waited for PHP 8.0, Symfony 5.2 and Symplify 9 to be released. We tested many PHP 8 rules for edge cases, so we could fix those and give you the final version.
How to Test Rector 0.9?
We want to let it out this week and we need your help with testing:
The more feedback we have on Rector 0.9, the sooner we can release it.
How to Upgrade?
Know changes between 0.8 and 0.9 are mentioned here: https://github.com/rectorphp/rector/blob/master/UPGRADE_09.md
Is something missing? Please create and issues, or if you want to help up, change the file and send us a PR.
The text was updated successfully, but these errors were encountered: