Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnnotationToAttribute trailing comma problem #7372

Closed
ghost opened this issue Aug 15, 2022 · 0 comments · Fixed by rectorphp/rector-src#2766
Closed

AnnotationToAttribute trailing comma problem #7372

ghost opened this issue Aug 15, 2022 · 0 comments · Fixed by rectorphp/rector-src#2766
Labels

Comments

@ghost
Copy link

ghost commented Aug 15, 2022

Bug Report

Subject Details
Rector version e.g. v0.13.10 (invoke vendor/bin/rector --version)

Before:
* @ORM\JoinColumn(name="parent_id", referencedColumnName="id", nullable=true, )

After:
#[ORM\JoinColumn(name: 'parent_id', referencedColumnName: 'id', nullable: true, ')')]

The "before" annotation although not perfectly valid however does not break the code. On the other hand the "after" attribute is a breaking one.

Similar to #7271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
0 participants