Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Php80] Handle trailing comma on AnnotationToAttributeRector on Doctrine JoinColumn #2766

Merged
merged 3 commits into from
Aug 15, 2022
Merged

[Php80] Handle trailing comma on AnnotationToAttributeRector on Doctrine JoinColumn #2766

merged 3 commits into from
Aug 15, 2022

Conversation

samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @javaDeveloperKid

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@ghost
Copy link

ghost commented Aug 15, 2022

You rock @samsonasik! You fix, Tomas asks for reproducer repos 😄

@TomasVotruba
Copy link
Member

We'll try to sync this approach 😉

@TomasVotruba
Copy link
Member

Thank you @samsonasik 👍

@TomasVotruba TomasVotruba merged commit 1f6cea3 into main Aug 15, 2022
@TomasVotruba TomasVotruba deleted the trailing-comma branch August 15, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AnnotationToAttribute trailing comma problem
2 participants
@samsonasik @TomasVotruba