Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 Symfony notice #7434

Closed
kkmuffme opened this issue Aug 29, 2022 · 3 comments
Closed

PHP 8.1 Symfony notice #7434

kkmuffme opened this issue Aug 29, 2022 · 3 comments
Labels

Comments

@kkmuffme
Copy link

Since symfony/console 6.1: Relying on the static property $defaultName for setting a command name is deprecated. Add the RectorPrefix202208/Symfony/Component/Console/Attribute/AsCommand attribute to the RectorPrefix202208/Symfony/Component/Console/Command/DumpCompletionCommand class instead.
File: .../vendor/rector/rector/vendor/symfony/contracts/Deprecation/function.php on line 26
Since symfony/console 6.1: Relying on the static property $defaultDescription for setting a command description is deprecated. Add the RectorPrefix202208/Symfony/Component/Console/Attribute/AsCommand attribute to the RectorPrefix202208/Symfony/Component/Console/Command/DumpCompletionCommand class instead.
File: .../vendor/rector/rector/vendor/symfony/contracts/Deprecation/function.php on line 26

See #7430 (comment)

@kkmuffme kkmuffme added the bug label Aug 29, 2022
@TomasVotruba
Copy link
Member

TomasVotruba commented Aug 29, 2022

The goal of new issue is not to jump back and forth :) Now it's unclear if/where the discussion goes.

Could you form an issolated issue with exact steps to solve?

@kkmuffme
Copy link
Author

@\trigger_error(($package || $version ? "Since {$package} {$version}: " : '') . ($args ? \vsprintf($message, $args) : $message), \E_USER_DEPRECATED);

We do not really need to bubble up Symfony deprecations to Rector release, so removing this function seems the way to go.

Comment this line/empty this function will fix (= ignore) this issue.

@TomasVotruba
Copy link
Member

Fixed in 19fe61c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants