PHP 8.1 notices

[kkmuffme]

Bug Report

Subject	Details
Rector version	e.g. v0.14

Minimal PHP Code Causing Issue

• all rules enabled
• run rector with PHP 8.1 CLI

Constant FILE_TEXT is deprecated
phar:.../vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/ondrejmirtes/better-reflection/src/SourceLocator/SourceStubber/PhpStormStubs/CachingVisitor.php on line 162
Constant FILE_BINARY is deprecated
File: phar:.../vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/ondrejmirtes/better-reflection/src/SourceLocator/SourceStubber/PhpStormStubs/CachingVisitor.php on line 162

Since symfony/console 6.1: Relying on the static property $defaultName for setting a command name is deprecated. Add the RectorPrefix202208/Symfony/Component/Console/Attribute/AsCommand attribute to the RectorPrefix202208/Symfony/Component/Console/Command/DumpCompletionCommand class instead.
File: .../vendor/rector/rector/vendor/symfony/contracts/Deprecation/function.php on line 26
Since symfony/console 6.1: Relying on the static property $defaultDescription for setting a command description is deprecated. Add the RectorPrefix202208/Symfony/Component/Console/Attribute/AsCommand attribute to the RectorPrefix202208/Symfony/Component/Console/Command/DumpCompletionCommand class instead.
File: .../vendor/rector/rector/vendor/symfony/contracts/Deprecation/function.php on line 26

There may be more, I just grabbed the first I saw. Since they are in dependencies inside of rector I thought I report it here then upstream

[samsonasik]

Could you narrow it down to specific rules and the code that cause it? For multiple rules applied, you can create failing test case PR to
https://github.com/rectorphp/rector-src/tree/main/tests/Issues

You can copy and modify on of the tests

[TomasVotruba]

This has to be solved in the project themselves. We only use those here :)

[kkmuffme]

symfony/symfony#47418

[TomasVotruba]

The DumpCompletionCommand is a Symfony command.

[kkmuffme]

Thanks, I reported both.
For the moment this means Rector is not compatible with PHP8.1 though, as even the most minimalistic config (any rule) has PHP notices.

3 line rector.php for confirming this issue:

return static function (\Rector\Config\RectorConfig $rectorConfig): void {
    $rectorConfig->rule(\Rector\CodeQuality\Rector\Include_\AbsolutizeRequireAndIncludePathRector::class);
};

[stof]

In Symfony, the attribute is there: https://github.com/symfony/symfony/blob/ddaedd28bd2e4fc22b64567753cf934fe9d68c4c/src/Symfony/Component/Console/Command/DumpCompletionCommand.php#L27

[TomasVotruba]

So is in Rector: https://github.com/rectorphp/rector/blob/main/vendor/symfony/console/Command/DumpCompletionCommand.php#L25

But Symfony checks the static property that is being downgraded to PHP 7.2. That's side effect of downgrade.

What can we do about it here?

[TomasVotruba]

For the moment this means Rector is not compatible with PHP8.1 though, as even the most minimalistic config (any rule) has PHP notices.

It is :). The deprecation on framework side is false positive here.

[TomasVotruba]

@kkmuffme How does it change if you comment this line in your local Rector vendor?

rector/vendor/symfony/contracts/Deprecation/function.php

Line 26 in 1d28ca1

@\trigger_error(($package || $version ? "Since {$package} {$version}: " : '') . ($args ? \vsprintf($message, $args) : $message), \E_USER_DEPRECATED);

We do not really need to bubble up Symfony deprecations to Rector release, so removing this function seems the way to go.

[kkmuffme]

@TomasVotruba yes, then that notice is gone for symfony.
Could you please reopen this issue?

===

phpstan notice:
the line numbers don't match up with the latest phpstan version at all, is rector on the latest phpstan version? (as the issue might be fixed there already)

===

There are 2 phpstan.phar in rector, is this on purpose?
rector/vendor/bin/phpstan.phar
rector/vendor/phpstan/phpstan/phpstan.phar

[TomasVotruba]

Could you create a new issue with the Symfony notice only? To keep it clean

[stof]

@TomasVotruba if you want to support PHP 7.2, why not using the Symfony 5.4 LTS which supports PHP 7.2 and so does not deprecate features that are necessary when using PHP 8- due to not being able to use attributes ?

[kkmuffme]

@TomasVotruba phpstan issue is also fixed:
phpstan/phpstan#7873

Does rector use a custom error handler that picks this up despite snoozed/@ ? (or is this something in my PHP setup?)

[TomasVotruba]

@stof Because we run on Symfony 6 with most of the deps already. It's easier for us to the use latest deps in general. The downgrade should work propperly in general, not just for Rector. If someone uses Rector to downgrade their Symfony 6 project, it should be allright.

[TomasVotruba]

@kkmuffme That would be here https://github.com/rectorphp/rector-src/blob/58a577c5b3d34cc70ba6ea713e7a6c7bbe66354e/src/Application/ApplicationFileProcessor.php#L192

[TomasVotruba]

@kkmuffme > There are 2 phpstan.phar in rector, is this on purpose?

The vendor/bin/* in composer is usually simlinked bin files from the package itself.

[kkmuffme]

@TomasVotruba #7430 (comment) What's your suggestion?
rector will throw 100s of notices with PHP 8.1 due to this

This has to be solved in the project themselves. We only use those here :)

😁

[TomasVotruba]

@kkmuffme I'd try to debug the error handler, why it passed your notices :)

They seem skipped: https://github.com/rectorphp/rector-src/blob/58a577c5b3d34cc70ba6ea713e7a6c7bbe66354e/src/Application/ApplicationFileProcessor.php#L183