Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Changelog] Re-generate Changelog #5719

Closed
wants to merge 1 commit into from
Closed

Conversation

samsonasik
Copy link
Member

No description provided.

@samsonasik
Copy link
Member Author

@TomasVotruba the Latest 0.9.* release header generated seems only 0.9.30 and 0.9.31, is it ok?

- [#5717] [Downgrade] Remove excessive abstract class inheritance, use single service
- [#5714] Removing parent classes
- [#5713] remove unmatched errors + require string in object types to avoid prefixing of generics objects

### Added
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is "added" section twice now, it should be just once per release

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's seems the limitation of current changelog merge

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current state of merge seems quite problematic. We have to find out what is the last tag, if it is relased or not and then somehow put merge two lists. It leads mostly to bugs and broken output.

Instead the whole changelog could be generated instead.
The only limite we can add is --since-tag, so we can create changelog for specific version, e.g. Symplify 8+.

That would save us lot of content juggling :)

What do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that seems the way to go, is the since-tag exists?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, both is just theory

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you handle this in Symplify?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try

@TomasVotruba
Copy link
Member

TomasVotruba commented Mar 2, 2021

@samsonasik

@TomasVotruba the Latest 0.9.* release header generated seems only 0.9.30 and 0.9.31, is it ok?

Are the previous version like 0.9.29 included too? Then it's ok IMO

@samsonasik
Copy link
Member Author

The not included is the "header tag", eg: "## [0.9.29] - yyyy-mm-dd", the changelog list seems generated.

samsonasik added a commit that referenced this pull request Mar 7, 2021
It seems automatic PR #5789 doesn't generate tag header like manual delete and re-create at #5719 . 

This ensure CHANGELOG.md re-generated by remove it first.
TomasVotruba pushed a commit that referenced this pull request Mar 7, 2021
…n weekly composer changelog (#5790)

It seems automatic PR #5789 doesn't generate tag header like manual delete and re-create at #5719 . 

This ensure CHANGELOG.md re-generated by remove it first.
TomasVotruba pushed a commit to deprecated-packages/rector-prefixed that referenced this pull request Mar 7, 2021
…n weekly composer changelog (#5790)

It seems automatic PR rectorphp/rector#5789 doesn't generate tag header like manual delete and re-create at rectorphp/rector#5719 .

This ensure CHANGELOG.md re-generated by remove it first.
@samsonasik
Copy link
Member Author

closing due no longer used.

@samsonasik samsonasik closed this Mar 11, 2021
@samsonasik samsonasik deleted the re-generate-changelog branch March 11, 2021 10:51
TomasVotruba added a commit that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants