-
-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Changelog] Re-generate Changelog #5719
Conversation
@TomasVotruba the Latest |
- [#5717] [Downgrade] Remove excessive abstract class inheritance, use single service | ||
- [#5714] Removing parent classes | ||
- [#5713] remove unmatched errors + require string in object types to avoid prefixing of generics objects | ||
|
||
### Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is "added" section twice now, it should be just once per release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's seems the limitation of current changelog merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current state of merge seems quite problematic. We have to find out what is the last tag, if it is relased or not and then somehow put merge two lists. It leads mostly to bugs and broken output.
Instead the whole changelog could be generated instead.
The only limite we can add is --since-tag
, so we can create changelog for specific version, e.g. Symplify 8+.
That would save us lot of content juggling :)
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that seems the way to go, is the since-tag
exists?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet, both is just theory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you handle this in Symplify?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try
Are the previous version like 0.9.29 included too? Then it's ok IMO |
The not included is the "header tag", eg: "## [0.9.29] - yyyy-mm-dd", the changelog list seems generated. |
…n weekly composer changelog (#5790) It seems automatic PR rectorphp/rector#5789 doesn't generate tag header like manual delete and re-create at rectorphp/rector#5719 . This ensure CHANGELOG.md re-generated by remove it first.
closing due no longer used. |
rectorphp/rector-src@fbba860 [Php80] Skip ObjectType on ChangeSwitchToMatchRector (#5719)
No description provided.