Add failing test fixture for DowngradeParameterTypeWideningRector

[leoloso]

Failing Test for DowngradeParameterTypeWideningRector

Based on https://getrector.org/demo/1b8ee6a0-7d50-4fae-8e15-f19d19591fc5

Fixes #5994

[leoloso]

Issue: #5994

[leoloso]

Alright, bug fixed!

Traits must be skipped for this rule, so I added:

if ($ancestorClassReflection->isTrait()) {
    continue;
}

Please check and merge 🙏

[TomasVotruba]

Thank you Leo

[samsonasik]

@leoloso it possibly cause issue on rector prefixed build which string parameter not removed:

https://github.com/rectorphp/rector-prefixed/blob/056cdf6b69602977e4227fe74e2c8b55ecb26c7f/vendor/symfony/service-contracts/ServiceLocatorTrait.php#L41

so make error:

PHP Fatal error:  Declaration of RectorPrefix20210420\Symfony\Component\DependencyInjection\ServiceLocator::has(string $id) must be compatible with RectorPrefix20210420\Psr\Container\ContainerInterface::has($id) in /home/runner/work/rector-prefixed/rector-prefixed/vendor/symfony/dependency-injection/ServiceLocator.php on line 25

Fatal error: Declaration of RectorPrefix20210420\Symfony\Component\DependencyInjection\ServiceLocator::has(string $id) must be compatible with RectorPrefix20210420\Psr\Container\ContainerInterface::has($id) in /home/runner/work/rector-prefixed/rector-prefixed/vendor/symfony/dependency-injection/ServiceLocator.php on line 25
Error: Process completed with exit code 255.

[leoloso]

I don't think this code I added is the one causing the issue.

I explained in #6176 but also, this rule was originally modifying code in the class, if it implemented a trait:

foreach ($classReflection->getAncestors() as $ancestorClassReflection) {

But that's an error, because the same method defined in the class will override the one from the trait (check the fixture I added).

And in any case, the offending code is in the trait ServiceLocatorTrait, not in the class.

So these are related, but different issues.

[samsonasik]

@leoloso thank you for verify 👍