-
-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not prefix "parent", "self", "static" and native constants #6159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
prefix-parent
branch
2 times, most recently
from
April 17, 2021 11:11
562421e
to
e4a6e33
Compare
samsonasik
reviewed
Apr 17, 2021
} | ||
|
||
$fullyQualifiedName = $this->nodeNameResolver->getName($node); | ||
if (in_array($fullyQualifiedName, ['self', 'parent'], true)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is static
need to be included as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be 👍 thanks
TomasVotruba
force-pushed
the
prefix-parent
branch
from
April 17, 2021 11:32
d8eb3c3
to
b68d1be
Compare
TomasVotruba
changed the title
Do not prefix parent
Do not prefix "parent", "self", "static" and native constants
Apr 17, 2021
TomasVotruba
force-pushed
the
prefix-parent
branch
2 times, most recently
from
April 17, 2021 11:46
f7509db
to
733be85
Compare
TomasVotruba
force-pushed
the
prefix-parent
branch
from
April 17, 2021 12:00
4ef37c7
to
01afd01
Compare
TomasVotruba
added a commit
that referenced
this pull request
Jul 18, 2024
rectorphp/rector-src@a3f0b1f [TypeDeclaration] Prevent uncaught exception in ReturnTypeFromReturnNewRector (#6159)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6146