Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not prefix "parent", "self", "static" and native constants #6159

Merged
merged 6 commits into from
Apr 17, 2021
Merged

Do not prefix "parent", "self", "static" and native constants #6159

merged 6 commits into from
Apr 17, 2021

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Apr 17, 2021 •
edited
Loading

Closes #6146

@TomasVotruba TomasVotruba changed the title do not prefix parent Do not prefix parent Apr 17, 2021
@TomasVotruba TomasVotruba force-pushed the prefix-parent branch 2 times, most recently from 562421e to e4a6e33 Compare April 17, 2021 11:11
samsonasik
samsonasik reviewed Apr 17, 2021
View reviewed changes
rules/PSR4/NodeManipulator/FullyQualifyStmtsAnalyzer.php Outdated
}

$fullyQualifiedName = $this->nodeNameResolver->getName($node);
if (in_array($fullyQualifiedName, ['self', 'parent'], true)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is static need to be included as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 👍 thanks

@TomasVotruba TomasVotruba changed the title Do not prefix parent Do not prefix "parent", "self", "static" and native constants Apr 17, 2021
@TomasVotruba TomasVotruba force-pushed the prefix-parent branch 2 times, most recently from f7509db to 733be85 Compare April 17, 2021 11:46
@TomasVotruba TomasVotruba enabled auto-merge (squash) April 17, 2021 11:49
@TomasVotruba TomasVotruba merged commit e8a76e8 into main Apr 17, 2021
@TomasVotruba TomasVotruba deleted the prefix-parent branch April 17, 2021 12:09
@TomasVotruba TomasVotruba mentioned this pull request Apr 17, 2021
Closed
TomasVotruba added a commit that referenced this pull request Jul 18, 2024
@TomasVotruba
Updated Rector to commit a3f0b1f21f60b21e4f357d3c7e6187b14bfa3ed2
21475d5 
rectorphp/rector-src@a3f0b1f [TypeDeclaration] Prevent uncaught exception in ReturnTypeFromReturnNewRector (#6159)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

General pretty printing guidance
2 participants
@TomasVotruba @samsonasik