rename to NoParamTypeRemoval rule

rectorphp · May 28, 2024 · 5131f17 · 5131f17
1 parent 04121be
commit 5131f17
Show file tree

Hide file tree

Showing 25 changed files with 85 additions and 85 deletions.
diff --git a/src/Rules/ForbiddenParamTypeRemovalRule.php → src/Rules/NoParamTypeRemovalRule.php b/src/Rules/ForbiddenParamTypeRemovalRule.php → src/Rules/NoParamTypeRemovalRule.php
@@ -17,7 +17,7 @@
  * @see \Rector\TypePerfect\Tests\Rules\ForbiddenParamTypeRemovalRule\ForbiddenParamTypeRemovalRuleTest
  * @implements Rule<ClassMethod>
  */
-final readonly class ForbiddenParamTypeRemovalRule implements Rule
+final readonly class NoParamTypeRemovalRule implements Rule
 {
     /**
      * @var string

diff --git a/tests/Rules/ForbiddenParamTypeRemovalRule/Fixture/RemoveParentType.php b/tests/Rules/ForbiddenParamTypeRemovalRule/Fixture/RemoveParentType.php
diff --git a/tests/Rules/ForbiddenParamTypeRemovalRule/Fixture/SkipNoParent.php b/tests/Rules/ForbiddenParamTypeRemovalRule/Fixture/SkipNoParent.php
diff --git a/tests/Rules/ForbiddenParamTypeRemovalRule/Fixture/SkipNoType.php b/tests/Rules/ForbiddenParamTypeRemovalRule/Fixture/SkipNoType.php
diff --git a/tests/Rules/ForbiddenParamTypeRemovalRule/Fixture/SkipPresentType.php b/tests/Rules/ForbiddenParamTypeRemovalRule/Fixture/SkipPresentType.php
diff --git a/tests/Rules/ForbiddenParamTypeRemovalRule/Source/SomeNode.php b/tests/Rules/ForbiddenParamTypeRemovalRule/Source/SomeNode.php
diff --git a/...amTypeRemovalRule/Fixture/AnInterface.php → ...amTypeRemovalRule/Fixture/AnInterface.php b/...amTypeRemovalRule/Fixture/AnInterface.php → ...amTypeRemovalRule/Fixture/AnInterface.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Rector\TypePerfect\Tests\Rules\ForbiddenParamTypeRemovalRule\Fixture;
+namespace Rector\TypePerfect\Tests\Rules\NoParamTypeRemovalRule\Fixture;
 
 interface AnInterface
 {

diff --git a/...eRemovalRule/Fixture/AnInterfaceOther.php → ...eRemovalRule/Fixture/AnInterfaceOther.php b/...eRemovalRule/Fixture/AnInterfaceOther.php → ...eRemovalRule/Fixture/AnInterfaceOther.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Rector\TypePerfect\Tests\Rules\ForbiddenParamTypeRemovalRule\Fixture;
+namespace Rector\TypePerfect\Tests\Rules\NoParamTypeRemovalRule\Fixture;
 
 use stdClass;
 

diff --git a/...DifferentParameterWithInterfaceMethod.php → ...DifferentParameterWithInterfaceMethod.php b/...DifferentParameterWithInterfaceMethod.php → ...DifferentParameterWithInterfaceMethod.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Rector\TypePerfect\Tests\Rules\ForbiddenParamTypeRemovalRule\Fixture;
+namespace Rector\TypePerfect\Tests\Rules\NoParamTypeRemovalRule\Fixture;
 
 class HasDifferentParameterWithInterfaceMethod implements AnInterface, AnInterfaceOther
 {

diff --git a/...HasDifferentParameterWithParentMethod.php → ...HasDifferentParameterWithParentMethod.php b/...HasDifferentParameterWithParentMethod.php → ...HasDifferentParameterWithParentMethod.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Rector\TypePerfect\Tests\Rules\ForbiddenParamTypeRemovalRule\Fixture;
+namespace Rector\TypePerfect\Tests\Rules\NoParamTypeRemovalRule\Fixture;
 
 class HasDifferentParameterWithParentMethod extends ParentClass
 {

diff --git a/...amTypeRemovalRule/Fixture/ParentClass.php → ...amTypeRemovalRule/Fixture/ParentClass.php b/...amTypeRemovalRule/Fixture/ParentClass.php → ...amTypeRemovalRule/Fixture/ParentClass.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Rector\TypePerfect\Tests\Rules\ForbiddenParamTypeRemovalRule\Fixture;
+namespace Rector\TypePerfect\Tests\Rules\NoParamTypeRemovalRule\Fixture;
 
 class ParentClass
 {

diff --git a/tests/Rules/NoParamTypeRemovalRule/Fixture/RemoveParentType.php b/tests/Rules/NoParamTypeRemovalRule/Fixture/RemoveParentType.php
@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\TypePerfect\Tests\Rules\NoParamTypeRemovalRule\Fixture;
+
+use Rector\TypePerfect\Tests\Rules\NoParamTypeRemovalRule\Source\SomeRectorInterface;
+
+final class RemoveParentType implements SomeRectorInterface
+{
+    public function refactor($node)
+    {
+    }
+}
diff --git a/...ipHasSameParameterWithInterfaceMethod.php → ...ipHasSameParameterWithInterfaceMethod.php b/...ipHasSameParameterWithInterfaceMethod.php → ...ipHasSameParameterWithInterfaceMethod.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Rector\TypePerfect\Tests\Rules\ForbiddenParamTypeRemovalRule\Fixture;
+namespace Rector\TypePerfect\Tests\Rules\NoParamTypeRemovalRule\Fixture;
 
 use stdClass;
 

diff --git a/.../SkipHasSameParameterWithParentMethod.php → .../SkipHasSameParameterWithParentMethod.php b/.../SkipHasSameParameterWithParentMethod.php → .../SkipHasSameParameterWithParentMethod.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Rector\TypePerfect\Tests\Rules\ForbiddenParamTypeRemovalRule\Fixture;
+namespace Rector\TypePerfect\Tests\Rules\NoParamTypeRemovalRule\Fixture;
 
 class SkipHasSameParameterWithParentMethod extends ParentClass
 {

diff --git a/...movalRule/Fixture/SkipIndirectRemoval.php → ...movalRule/Fixture/SkipIndirectRemoval.php b/...movalRule/Fixture/SkipIndirectRemoval.php → ...movalRule/Fixture/SkipIndirectRemoval.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Rector\TypePerfect\Tests\Rules\ForbiddenParamTypeRemovalRule\Fixture;
+namespace Rector\TypePerfect\Tests\Rules\NoParamTypeRemovalRule\Fixture;
 
 use Symfony\Component\DependencyInjection\Loader\PhpFileLoader;
 

diff --git a/tests/Rules/NoParamTypeRemovalRule/Fixture/SkipNoParent.php b/tests/Rules/NoParamTypeRemovalRule/Fixture/SkipNoParent.php
@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\TypePerfect\Tests\Rules\NoParamTypeRemovalRule\Fixture;
+
+class SkipNoParent
+{
+}
diff --git a/tests/Rules/NoParamTypeRemovalRule/Fixture/SkipNoType.php b/tests/Rules/NoParamTypeRemovalRule/Fixture/SkipNoType.php
@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\TypePerfect\Tests\Rules\NoParamTypeRemovalRule\Fixture;
+
+use Rector\TypePerfect\Tests\Rules\NoParamTypeRemovalRule\Source\NoTypeInterface;
+
+final class SkipNoType implements NoTypeInterface
+{
+    public function noType($node)
+    {
+    }
+}
diff --git a/...alRule/Fixture/SkipNotHasParentMethod.php → ...alRule/Fixture/SkipNotHasParentMethod.php b/...alRule/Fixture/SkipNotHasParentMethod.php → ...alRule/Fixture/SkipNotHasParentMethod.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Rector\TypePerfect\Tests\Rules\ForbiddenParamTypeRemovalRule\Fixture;
+namespace Rector\TypePerfect\Tests\Rules\NoParamTypeRemovalRule\Fixture;
 
 class SkipNotHasParentMethod extends ParentClass
 {

diff --git a/...ypeRemovalRule/Fixture/SkipPhpDocType.php → ...ypeRemovalRule/Fixture/SkipPhpDocType.php b/...ypeRemovalRule/Fixture/SkipPhpDocType.php → ...ypeRemovalRule/Fixture/SkipPhpDocType.php
@@ -2,9 +2,9 @@
 
 declare(strict_types=1);
 
-namespace Rector\TypePerfect\Tests\Rules\ForbiddenParamTypeRemovalRule\Fixture;
+namespace Rector\TypePerfect\Tests\Rules\NoParamTypeRemovalRule\Fixture;
 
-use Rector\TypePerfect\Tests\Rules\ForbiddenParamTypeRemovalRule\Source\PhpDocType;
+use Rector\TypePerfect\Tests\Rules\NoParamTypeRemovalRule\Source\PhpDocType;
 
 final class SkipPhpDocType extends PhpDocType
 {

diff --git a/tests/Rules/NoParamTypeRemovalRule/Fixture/SkipPresentType.php b/tests/Rules/NoParamTypeRemovalRule/Fixture/SkipPresentType.php
@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\TypePerfect\Tests\Rules\NoParamTypeRemovalRule\Fixture;
+
+use Rector\TypePerfect\Tests\Rules\NoParamTypeRemovalRule\Source\SomeNode;
+use Rector\TypePerfect\Tests\Rules\NoParamTypeRemovalRule\Source\SomeRectorInterface;
+
+final class SkipPresentType implements SomeRectorInterface
+{
+    public function refactor(SomeNode $node)
+    {
+    }
+}
diff --git a/...ule/ForbiddenParamTypeRemovalRuleTest.php → ...emovalRule/NoParamTypeRemovalRuleTest.php b/...ule/ForbiddenParamTypeRemovalRuleTest.php → ...emovalRule/NoParamTypeRemovalRuleTest.php
@@ -2,15 +2,15 @@
 
 declare(strict_types=1);
 
-namespace Rector\TypePerfect\Tests\Rules\ForbiddenParamTypeRemovalRule;
+namespace Rector\TypePerfect\Tests\Rules\NoParamTypeRemovalRule;
 
 use Iterator;
 use PHPStan\Rules\Rule;
 use PHPStan\Testing\RuleTestCase;
 use PHPUnit\Framework\Attributes\DataProvider;
-use Rector\TypePerfect\Rules\ForbiddenParamTypeRemovalRule;
+use Rector\TypePerfect\Rules\NoParamTypeRemovalRule;
 
-final class ForbiddenParamTypeRemovalRuleTest extends RuleTestCase
+final class NoParamTypeRemovalRuleTest extends RuleTestCase
 {
     /**
      * @param mixed[] $expectedErrorMessagesWithLines
@@ -29,7 +29,7 @@ public static function provideData(): Iterator
 
         yield [__DIR__ . '/Fixture/SkipIndirectRemoval.php', []];
 
-        yield [__DIR__ . '/Fixture/RemoveParentType.php', [[ForbiddenParamTypeRemovalRule::ERROR_MESSAGE, 11]]];
+        yield [__DIR__ . '/Fixture/RemoveParentType.php', [[NoParamTypeRemovalRule::ERROR_MESSAGE, 11]]];
 
         yield [__DIR__ . '/Fixture/SkipNoParent.php', []];
         yield [__DIR__ . '/Fixture/SkipNotHasParentMethod.php', []];
@@ -38,12 +38,12 @@ public static function provideData(): Iterator
 
         yield [
             __DIR__ . '/Fixture/HasDifferentParameterWithParentMethod.php',
-            [[ForbiddenParamTypeRemovalRule::ERROR_MESSAGE, 9]],
+            [[NoParamTypeRemovalRule::ERROR_MESSAGE, 9]],
         ];
         yield [
             __DIR__ . '/Fixture/HasDifferentParameterWithInterfaceMethod.php',
-            [[ForbiddenParamTypeRemovalRule::ERROR_MESSAGE, 9], [
-                ForbiddenParamTypeRemovalRule::ERROR_MESSAGE,
+            [[NoParamTypeRemovalRule::ERROR_MESSAGE, 9], [
+                NoParamTypeRemovalRule::ERROR_MESSAGE,
                 13,
             ]],
         ];
@@ -59,6 +59,6 @@ public static function getAdditionalConfigFiles(): array
 
     protected function getRule(): Rule
     {
-        return self::getContainer()->getByType(ForbiddenParamTypeRemovalRule::class);
+        return self::getContainer()->getByType(NoParamTypeRemovalRule::class);
     }
 }
diff --git a/...ypeRemovalRule/Source/NoTypeInterface.php → ...ypeRemovalRule/Source/NoTypeInterface.php b/...ypeRemovalRule/Source/NoTypeInterface.php → ...ypeRemovalRule/Source/NoTypeInterface.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Rector\TypePerfect\Tests\Rules\ForbiddenParamTypeRemovalRule\Source;
+namespace Rector\TypePerfect\Tests\Rules\NoParamTypeRemovalRule\Source;
 
 interface NoTypeInterface
 {

diff --git a/...aramTypeRemovalRule/Source/PhpDocType.php → ...aramTypeRemovalRule/Source/PhpDocType.php b/...aramTypeRemovalRule/Source/PhpDocType.php → ...aramTypeRemovalRule/Source/PhpDocType.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Rector\TypePerfect\Tests\Rules\ForbiddenParamTypeRemovalRule\Source;
+namespace Rector\TypePerfect\Tests\Rules\NoParamTypeRemovalRule\Source;
 
 class PhpDocType
 {

diff --git a/tests/Rules/NoParamTypeRemovalRule/Source/SomeNode.php b/tests/Rules/NoParamTypeRemovalRule/Source/SomeNode.php
@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\TypePerfect\Tests\Rules\NoParamTypeRemovalRule\Source;
+
+final class SomeNode
+{
+
+}
diff --git a/...emovalRule/Source/SomeRectorInterface.php → ...emovalRule/Source/SomeRectorInterface.php b/...emovalRule/Source/SomeRectorInterface.php → ...emovalRule/Source/SomeRectorInterface.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Rector\TypePerfect\Tests\Rules\ForbiddenParamTypeRemovalRule\Source;
+namespace Rector\TypePerfect\Tests\Rules\NoParamTypeRemovalRule\Source;
 
 interface SomeRectorInterface
 {