Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NarrowPublicClassMethodParamTypeRuleTest: Skip array-generics failling test #38

Closed
wants to merge 1 commit into from
Closed

NarrowPublicClassMethodParamTypeRuleTest: Skip array-generics failling test #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions tests/Rules/NarrowPublicClassMethodParamTypeRule/Fixture/SkipArrayGenerics.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?php

declare(strict_types=1);

namespace Rector\TypePerfect\Tests\Rules\NarrowPublicClassMethodParamTypeRule\Fixture;

class SkipArrayGenerics
{
public function run(array $aArray = [])
{
}

}
6 changes: 6 additions & 0 deletions ...s/Rules/NarrowPublicClassMethodParamTypeRule/NarrowPublicClassMethodParamTypeRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,12 @@ public static function provideData(): Iterator
yield [[
__DIR__ . '/Fixture/HandleDefaultValue.php',
], [[$argErrorMessage, 15]]];

yield [[
__DIR__ . '/Fixture/SkipArrayGenerics.php',
__DIR__ . '/Source/ArrayCaller.php',
], []];

}

/**
Expand Down
20 changes: 20 additions & 0 deletions tests/Rules/NarrowPublicClassMethodParamTypeRule/Source/ArrayCaller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<?php

declare(strict_types=1);

namespace Rector\TypePerfect\Tests\Rules\NarrowPublicClassMethodParamTypeRule\Source;

use Rector\TypePerfect\Tests\Rules\NarrowPublicClassMethodParamTypeRule\Fixture\PublicDoubleShot;
use Rector\TypePerfect\Tests\Rules\NarrowPublicClassMethodParamTypeRule\Fixture\SkipArrayGenerics;

final class ArrayCaller
{
public function doRun(SkipArrayGenerics $r) {
$r->run(['hello' => 'abc']);
}

public function doRun2(SkipArrayGenerics $r) {
$r->run();
}

}
Loading