Early return Collectors when narrow-param is disabled #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collectors store their data in the PHPStan result cache. we shouldn't pollute the result cache with data if we don't need it.
looking at the sources it seems these 3 collectors are only used for
NarrowPublicClassMethodParamTypeRule
and this rule has a configuration flag to early return if not enabled.with this PR we now use the same configuration flag to early return in the related collectors
this PR came together because it turned out that one of the
type-perfect
collectors was by-far the most result-cache polluting component in our project:after his PR the result-cache of said project shrunk by ~16% in file-size - because we don't use
narrow_param
in our projects - which in turn makes phpstan analysis faster and less memory hungry