Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version scoped url to go.mod and install instructions #30

Merged
merged 1 commit into from
May 20, 2020

Conversation

bhelx
Copy link
Contributor

@bhelx bhelx commented May 20, 2020

golang/go#35732

It looks like our install instructions fall into this pseudo-version
trap mentioned in the above issue. This adds the v3 scope to the url
and it updates the bump script to make sure that the number stays up to
date.

Testing

testing that the bump script is updating the right stuff. Should only change things on major version bumps:

[I] ⋊> ~/r/v/c/go  ./scripts/bump major                                                                                                                                          
[I] ⋊> ~/r/v/c/go ⨯ git diff                                                                                                                                                     
diff --git a/.bumpversion.cfg b/.bumpversion.cfg
index 1877afb..9b66879 100644
--- a/.bumpversion.cfg
+++ b/.bumpversion.cfg
@@ -1,5 +1,5 @@
 [bumpversion]
-current_version = 3.0.0
+current_version = 4.0.0
 parse = (?P<major>\d+)
        \.(?P<minor>\d+)
        \.(?P<patch>\d+)
diff --git a/README.md b/README.md
index 784c055..5edcfdd 100644
--- a/README.md
+++ b/README.md
@@ -11,14 +11,14 @@ Documentation for the HTTP API and example code can be found [on our Developer H
 Install using `go get`:

 \`\`\`
-go get -u github.com/recurly/recurly-client-go/v3
+go get -u github.com/recurly/recurly-client-go/v4
 \`\`\`

 import with:

 \`\`\`go
 import (
-    "github.com/recurly/recurly-client-go/v3"
+    "github.com/recurly/recurly-client-go/v4"
 )
 \`\`\`

diff --git a/go.mod b/go.mod
index 69a2af1..bc8e71b 100644
--- a/go.mod
+++ b/go.mod
@@ -1,3 +1,3 @@
-module github.com/recurly/recurly-client-go/v3
+module github.com/recurly/recurly-client-go/v4

 go 1.12
diff --git a/version.go b/version.go
index 625e5ec..d37aeba 100644
--- a/version.go
+++ b/version.go
@@ -1,5 +1,5 @@
 package recurly

 const (
-       clientVersion = "3.0.0"
+       clientVersion = "4.0.0"
 )

golang/go#35732

It looks like our install instructions fall into this [pseudo-version](https://golang.org/cmd/go/#hdr-Pseudo_versions)
trap mentioned in the above issue. This adds the `v3` scope to the url
and it updated the bump script to make sure that the number stays up to
date.
@bhelx bhelx requested review from douglasmiller and nilslice May 20, 2020 17:12
@bhelx bhelx added bug Something isn't working WIP labels May 20, 2020
@bhelx bhelx changed the title Add version scoped url Add version scoped url to go.mod and install instructions May 20, 2020
@bhelx bhelx requested review from joannasese and removed request for douglasmiller May 20, 2020 17:20
@bhelx bhelx removed the WIP label May 20, 2020
@joannasese joannasese merged commit a67cccb into master May 20, 2020
@joannasese joannasese deleted the use-version-scoped-url branch May 20, 2020 17:23
@bhelx bhelx mentioned this pull request May 20, 2020
@jguidry-recurly jguidry-recurly added the V3 v2019-10-10 Client label Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working V3 v2019-10-10 Client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants