Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurly_InvoiceList::getForAccount(accountCode) Returns All Invoices #14

Closed
rawberg opened this issue Nov 4, 2011 · 4 comments
Closed
Labels
V2 V2 Client

Comments

@rawberg
Copy link

rawberg commented Nov 4, 2011

Looks like it's not forming the proper URL to only retrieve invoices for a specific account. Here is my patch to fix the issue.

public static function getForAccount($accountCode, $params = null, $client = null)
  {
    $list = new Recurly_InvoiceList(Recurly_Client::PATH_INVOICES, $client);
    $loadPath = Recurly_Client::PATH_ACCOUNTS . '/' . $accountCode . Recurly_Client::PATH_INVOICES;
    $list->_loadFrom($loadPath, $params);
    return $list;
  }
@seifip
Copy link

seifip commented Nov 4, 2011

I've recently reported a similar issue with Recurly_SubscriptionList::getForAccount(accountCode) and it was fixed in the latest revision.

@beauwest
Copy link

beauwest commented Nov 4, 2011

I've fixed this issue and submitted it with my pull request: https://github.com/recurly/recurly-client-php/pulls

You can find the source on my forked repository if you need it immediately.

@beauwest
Copy link

beauwest commented Nov 4, 2011

Whoops, looks like they already fixed this issue. Use theirs. :)

@isaachall
Copy link

Fixed with version 2.0.2. Thanks for reporting it.

bhelx added a commit that referenced this issue Aug 21, 2015
…n_account

support for multiple redemptions on accounts
@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 V2 Client
Projects
None yet
Development

No branches or pull requests

5 participants