Unable to Update Subscriptions using 2.5.* in Laravel 5.1

[ram651]

I am trying to update Subscriptions dynamically using the Recurly PHP Library under the Laravel 5.1 Framework. Since the library isn't designed with PSR-4 in mind, I had to add namespacing to the tops of each of the library files in order to reference them appropriately.

I believe that this might affect the behavior of the library, but as you can see in the below error, the context that the private method is being called from is the context of the Class itself the private method belongs to.

Error thrown:

FatalErrorException in base.php line 311:
Call to private method Recurly_Base::addLink() from context 'App\Libraries\Recurly\Recurly_Base'

This is an example of the modifications I made to the class files included in the Recurly PHP Client.

<?php    
    namespace App\Libraries\Recurly;

    use DateTime;
    use DOMDocument;

    abstract class Recurly_Base
    {

I can successfully use the library to generate subscriptions, but any time I try to update those subscriptions, I get this FatalErrorException thrown by PHP, and thrown by the same class I exampled above.

                        $user = $request->user();

            $subscription = Recurly_Subscription::get($user->recurly_subscription_code);// <- The offending line
            $subscription->plan_code = '<plan_code>';

            $user->subscription_pricing = $user->subscription_pricing + $newItemPrice;
            $user->updated_at = $user->freshTimestamp();


            $subscription->unit_amount_in_cents =  $user->subscription_pricing;

            $subscription->updateImmediately(); 

            $user->save();

It seems that for some reason, the Recurly_Base class cannot access it's own private method addLink.

I attempted to resolve the issue by weakening the Visibility of all Recurly_Base methods and values so that the 'private'-ness of addLink wouldn't matter, but the FatalErrorException was still thrown.

[cyruscollier]

I'm sure the authors of this library will add namespacing at some point, but why would you need to alter the library with namespaces to be compatible with Laravel? Using the standard Autoloading via Composer should allow you access to the Recurly classes directly or through the Laravel DI container.

[ram651]

There were issues with the heavy dependencies between classes and some
private methods, as I described above.

There is a PSR4-compliant version of the library, that someone made a pull
request for, that I pulled down and have been using successfully since then.

On Jul 25, 2016 8:35 AM, "Cyrus Collier" notifications@github.com wrote:

I'm sure the authors of this library will add namespacing at some point,
but why would you need to alter the library with namespaces to be
compatible with Laravel? Using the standard Autoloading via Composer should
allow you access to the Recurly classes directly or through the Laravel DI
container.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#253 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIZ5Ii3BFWYMa2D2UjYwbXz8dZn9ywA3ks5qZNe2gaJpZM4JN2VF
.

[drewish]

i just noticed https://packagist.org/packages/digital-canvas/recurly-client-laravel i'm not sure if it's up to date or what though.

[ram651]

That package was implemented for Laravel 4.1/4.2 whereas my project is in
Laravel 5.1, the LTS that modified how classes/packages are namespaced and
referenced from within the framework. Unfortunately, I had hoped that
package would have worked, but did not.

On Aug 1, 2016 12:12 PM, "andrew morton" notifications@github.com wrote:

i just noticed
https://packagist.org/packages/digital-canvas/recurly-client-laravel i'm
not sure if it's up to date or what though.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#253 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIZ5Il5JLKCIk668MjFz5zFnvfPrS6C2ks5qbkUMgaJpZM4JN2VF
.