fix for add charge. start_date and end_date was not getting set #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like it duplicates #220? Which one should we close? |
|
Oh actually seeing that this seems like it's a separate fix that was just branched off your other set of changes. Would you mind rebasing it on a clean copy of master and squashing down the repeated commits? |
|
Sorry. I missed to check that. I have removed the other branch changes. This has only start and end date fix now. |
|
Bump! |
|
Hi @imsagar could you please squash these down into a single commit? |
|
But if you'd rather not mess with the rebase I can take care of it in a separate PR. |
|
Hey. I'll close this pull request. Have sent you clean one here #229 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.