-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shipping Address Support #269
Conversation
36554cd
to
131e0d6
Compare
@@ -67,6 +67,7 @@ class Recurly_Client | |||
const PATH_INVOICES = '/invoices'; | |||
const PATH_NOTES = '/notes'; | |||
const PATH_PLANS = '/plans'; | |||
const PATH_SHIPPING_ADDRESSES = '/shipping_addresses'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love to just skip these constants.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, removing them.
} | ||
// protected function getRequiredAttributes() { | ||
// return array(); | ||
// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just drop this?
Tested this out and it's looking good. Let's whack the comment, add a CHANGELOG message and squash it down. |
510260c
to
e66d37a
Compare
@drewish thanks. Updated and squashed. |
+1 |
Adding shipping address support. Allows adding and removing multiple shipping addresses to/from an account. You can also add/remove a shipping address on a subscription.
Usage