Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse fraud risk rules #274

Merged
merged 1 commit into from
Sep 14, 2016
Merged

Parse fraud risk rules #274

merged 1 commit into from
Sep 14, 2016

Conversation

bhelx
Copy link
Contributor

@bhelx bhelx commented Sep 13, 2016

This adds code to parse the "risk rules" that were triggered in a fraud event

/**
* Represents the <rule> object in <risk_rules_triggered>
*/
class Recurly_FraudRiskRule
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this class name maybe too literal?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine

@bhelx bhelx force-pushed the fraud_info_risk_rules_triggered branch from 554bb01 to 73cf696 Compare September 13, 2016 22:53
@bhelx bhelx changed the base branch from master to api-2.4 September 13, 2016 22:53
@drewish
Copy link

drewish commented Sep 14, 2016

Let's add a changelog entry for this too

@bhelx bhelx force-pushed the fraud_info_risk_rules_triggered branch 2 times, most recently from 3712362 to 2ceb571 Compare September 14, 2016 17:26
@drewish
Copy link

drewish commented Sep 14, 2016

+1

@drewish drewish merged commit fe76d22 into api-2.4 Sep 14, 2016
@drewish drewish deleted the fraud_info_risk_rules_triggered branch September 15, 2016 20:02
@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 V2 Client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants