Adds external payments to invoices #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewish
reviewed
Mar 13, 2017
lib/recurly/invoice.php
Outdated
| * @param Recurly_Transaction additional transaction attributes. The attributes available to set are (payment_method, collected_at, amount_in_cents, description) | ||
| * @return Recurly_Transaction transaction on success | ||
| */ | ||
| public function enterOfflinePayment($transaction, $client = null) { |
There was a problem hiding this comment.
this shouldn't need the $client param unless it's a static method
There was a problem hiding this comment.
It's for the tests since this does call a static method. Is there a way around that?
There was a problem hiding this comment.
I could perhaps change this to
return Recurly_Transaction::_post($uri, $transaction->xml(), $this->_client);There was a problem hiding this comment.
yeah $this->client should have been set when the invoice was initialized.
bhelx
force-pushed
the
external_payments
branch
from
ca3e069 to
1d6b83e
Compare
bhelx
force-pushed
the
external_payments
branch
from
1d6b83e to
0e110fe
Compare
drewish
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #141
Adds the ability to "Enter an offline payment for a manual invoice". If this is merged, then the code example on that page will have to be updated. This picks up on the work of @cgerrior in PR #154