Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gateway_code to subscription and invoice #380

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

aaron-junot
Copy link

@aaron-junot aaron-junot commented Nov 19, 2018

Allows gateway_code to be updated via the subscription/notes endpoint and the PUT invoice endpoint

Scripts:

<?php
// Assumes subscription uuid "46c7ddb06e35530669baa445e3926e34" exists
include './scripts/php/stub.php';

$uuid = '46c7ddb06e35530669baa445e3926e34';
$sub = Recurly_Subscription::get($uuid);
$sub->updateNotes(array("gateway_code" => "jvkvq2er456m");
print("\n");
$invoice = Recurly_Invoice::get('1001');
$invoice->gateway_code = 'jvm7ol289raz';
$invoice->update();

Copy link

@drewish drewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but will wait for the WIP label to come off before merging.

@aaron-junot
Copy link
Author

Oh yeah, I'm going to go ahead and put the similar change to the Invoice object on this same PR and do a test. I'll ask you to take another look when I take off the WIP label

@aaron-junot aaron-junot force-pushed the aaron-suarez/gateway-routing branch 2 times, most recently from 0954bb6 to 5a3d7f8 Compare November 20, 2018 22:19
@aaron-junot aaron-junot removed the WIP label Nov 20, 2018
@aaron-junot aaron-junot changed the title Add gateway_code to subscription Add gateway_code to subscription and invoice Nov 20, 2018
@aaron-junot aaron-junot force-pushed the aaron-suarez/gateway-routing branch from 5a3d7f8 to 6b947f3 Compare November 20, 2018 22:56
Copy link
Contributor

@bhelx bhelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bhelx bhelx merged commit 7feef75 into api_version_2_17 Nov 26, 2018
@bhelx bhelx deleted the aaron-suarez/gateway-routing branch November 26, 2018 21:17
@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 V2 Client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants