-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify which versions of HHVM we should test in travis #399
Conversation
f4f8125
to
8b981b2
Compare
.travis.yml
Outdated
sudo: false | ||
dist: trusty | ||
install: | ||
- composer install --dev | ||
script: vendor/phpunit/phpunit/phpunit Tests | ||
matrix: | ||
allow_failures: | ||
- hhvm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to specify which version you will allow to fail
3969af1
to
125c5db
Compare
README.md
Outdated
@@ -115,6 +115,8 @@ $ vendor/bin/phpunit | |||
- [https://support.recurly.com](https://support.recurly.com) | |||
- [stackoverflow](http://stackoverflow.com/questions/tagged/recurly) | |||
|
|||
Note: Though our library may work on older versions of PHP, we only support [current versions of PHP](http://php.net/supported-versions.php), as well as current LTS versions of [HHVM](https://docs.hhvm.com/hhvm/installation/release-schedule) which support PHP and Composer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How something along these lines:
## Supported Versions
We support all ["currently supported versions" of PHP](http://php.net/supported-versions.php).
We also support the LTS versions of [HHVM](https://docs.hhvm.com/hhvm/installation/release-schedule) but only those which support PHP and Composer.
125c5db
to
13d38a4
Compare
13d38a4
to
d9a41e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
HHVM no longer supports Composer or PHP as of version 4.0.0. More information can be found in their blog. https://hhvm.com/blog/2019/02/11/hhvm-4.0.0.html