Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support billing_info on Subscription, Invoice & Gift card #424

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Support billing_info on Subscription, Invoice & Gift card #424

merged 1 commit into from
Sep 12, 2019

Conversation

vojtech-dobes
Copy link

Makes possible to resolve "three_d_secure_action_required" error triggered while:

  • creating subscription
  • updating subscription
  • collecting invoice
  • creating gift card

Support for this is mentioned in the SCA integration guide as well as documented on corresponding endpoints in API reference.

@vojtech-dobes
Support billing_info on Subscription, Invoice & Gift card
f2f96f4 
Makes possible to resolve "three_d_secure_action_required" error triggered while:
- creating subscription
- updating subscription
- collecting invoice
- creating gift card

Support for this is mentioned in the SCA integration guide as well as documented on corresponding endpoints in API reference.
@bhelx bhelx self-requested a review September 9, 2019 20:34
@vojtech-dobes
Copy link
Author

@bhelx I just want to clarify - unless we've misunderstood something, this seems hard necessity on Sep 14 2019.

@vojtech-dobes
Copy link
Author

vojtech-dobes commented Sep 12, 2019 •
edited
Loading

What is going on? Can’t you at least clarify that this isn’t needed or what?

It’s Sep 12. Tomorrow is last day and it ends considerably sooner in EU than in US.

Without these changes, passing 3Dsecure result token when updating subscription as described in your API reference simply doesn’t work. So unless we’re missing something, this library isn’t ready for PSD2.

bhelx
bhelx approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@bhelx bhelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bhelx bhelx merged commit 4b21f31 into recurly:master Sep 12, 2019
@bhelx
Copy link
Contributor

bhelx commented Sep 12, 2019

Hi @vojtech-dobes, thanks for the catch and the contribution! Due to the tight deadline on PSD2 we've been behind on some of the client library updates. We've reviewed and merged

@vojtech-dobes
Copy link
Author

Thanks! Will you also ship new version with it?

@bhelx
Copy link
Contributor

bhelx commented Sep 13, 2019

@vojtech-dobes i'm going to release a new version in the next 2 hours. The release should be linked back to this issue. Thanks again!

bhelx added a commit that referenced this pull request Sep 13, 2019
@bhelx
PSD2 billing info changes
e7b467f 
Covered in #424 but this adds property docs
@bhelx bhelx mentioned this pull request Sep 13, 2019
Merged
bhelx added a commit that referenced this pull request Sep 13, 2019
@bhelx
Release 2.12.6
e81a8c2 
* Support billing_info on Subscription, Invoice & Gift card [PR](#424)
* PSD2 billing info changes [PR](#426)
* Restore libxml state when changed [PR](#423)
@bhelx bhelx mentioned this pull request Sep 13, 2019
Merged
@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhelx bhelx bhelx approved these changes

Assignees
No one assigned
Labels
V2 V2 Client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vojtech-dobes @bhelx