Allow external domains for getFile() calls #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joannasese
force-pushed
the
dx-931-update-valid-domains
branch
from
f2ebd3d to
14495d8
Compare
joannasese
force-pushed
the
dx-931-update-valid-domains
branch
from
fbe5814 to
143e3ac
Compare
bhelx
changed the title
|
Could you change PR description to match the solution? |
|
@bhelx whoops sorry about that. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue 453.
verifyUrifromgetFile, which will allow external domains, e.g. s3.amazonaws.comWe've determined it's safe to remove this check because getFile is limited to calls that are not processed by the client and getFile does not send authentication or PII details to it's target server. Futhermore, the URL comes from Recurly's response so we can reasonably assume it will be safe to invoke. Removing this check allows us to change the downloads in the future if they move from s3.