Fix static deletion methods and add tests #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On #46 iclo pointed we have static delete methods calling into the non-static Recurly_Resource::_delete() causing a fatal error. I moved the _delete() method up to Recurly_Base and made it static, and adjusted all the deletion calls accordly. Transaction refunds are a special case since they're the only place we do a DELETE that returns a body. Since we had no tests, I spent a bit of time adding those, which required some changes to pass the mock client through.
|
Looks like a good update to me. Cleans up some code. |
drewish
added a commit
that referenced
this pull request
Feb 9, 2013
Fix static deletion methods and add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On #46 iclo pointed we have static delete methods calling into the non-static Recurly_Resource::_delete() causing a fatal error.
I moved the _delete() method up to Recurly_Base and made it static,
and adjusted all the deletion calls accordly. Transaction refunds are
a special case since they're the only place we do a DELETE that
returns a body. Since we had no tests, I spent a bit of time adding
those, which required some changes to pass the mock client through.