Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump 2.3.0 #90

Merged
merged 4 commits into from
May 19, 2014
Merged

bump 2.3.0 #90

merged 4 commits into from
May 19, 2014

Conversation

cbarton
Copy link
Member

@cbarton cbarton commented May 14, 2014

This adds tax details and new subscription preview

@@ -1,5 +1,10 @@
# Recurly PHP Client Library CHANGELOG

## Version 2.3.0.beta1 (May 14th, 2014)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we bumping to 2.3.0 or beta?

<plan_code>gold</plan_code>
<name>gold</name>
</plan>
<uuid>012345678901234567890123456789ab</uuid>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previews have UUID?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every object has a UUID in the system. It has no link to it since it has not been persisted.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, okay makes sense.

@drewish
Copy link

drewish commented May 19, 2014

Looks good 👍

drewish added a commit that referenced this pull request May 19, 2014
@drewish drewish merged commit ad2e996 into master May 19, 2014
@drewish drewish deleted the 2.3.0 branch May 19, 2014 18:30
@drewish
Copy link

drewish commented Aug 7, 2014

I should have made you write a test for the serialization of tax_exempt.

@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 V2 Client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants