bulk param #98
Merged
bulk param #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $subscription->plan_code = 'gold'; | ||
| $subscription->quantity = 1; | ||
| $subscription->currency = 'USD'; | ||
| $subscription->bulk = 'True'; |
There was a problem hiding this comment.
This would probably make more sense as the literal rather than a string.
There was a problem hiding this comment.
Also might as well just put that param onto an existing test case. I don't think it really needs to duplicate the full request.
This new parameter allows you to bypass the 60 second limit on adding
multiple subscriptions for the same plan to one account.
The boolean serialization to {0,1} was changed to {true,false} to match
the api. It was not being used by any of the other serializers so should
be backwards compatible.
Also adding a test for $account->tax_exempt to make sure false is
working correctly.
|
I'll let travis do it's thing but +1 looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new parameter allows you to bypass the 60 second limit on adding multiple subscriptions for the same plan to one account.
The boolean serialization to {0,1} was changed to {true,false} to match the api. It was not being used by any of the other serializers so should be backwards compatible.
Also adding a test for
$account->tax_exemptto make sure false is working correctly.