Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove X-Records header parsing #324

Merged
merged 1 commit into from
May 8, 2017

Conversation

bhelx
Copy link
Contributor

@bhelx bhelx commented Apr 18, 2017

We are removing the X-Records header in api version 2.6 on paginating GET requests
and they only come back on HEAD requests. Now calling Resource#count or Pager#count
will always explicitly call the server with a HEAD request. This should maybe be considered a breaking change:

To get a count, you'll need to explicitly call count which will call the server on each call.

params = {
  begin_time: Date.today.prev_month,
  order: :asc,
  sort: :created_at
}

count = Recurly::Transaction.where(params).count
puts count

@bhelx bhelx added the WIP label May 1, 2017
@bhelx bhelx force-pushed the api_version_2_6 branch from 5a59939 to 4679dac Compare May 3, 2017 20:18
@bhelx bhelx removed the WIP label May 5, 2017
@bhelx bhelx requested a review from lmnleaf May 5, 2017 19:06
@bhelx bhelx force-pushed the remove_x_records_header_parsing branch from 9bdcbe9 to 96c23c3 Compare May 5, 2017 19:09
Copy link

@lmnleaf lmnleaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

We are removing the X-Records header in api version 2.6 on paginating GET requests
and they only come back on HEAD requests. Now calling Resource#count
will always explicitly call the server. This is a breaking change.
@bhelx bhelx force-pushed the remove_x_records_header_parsing branch from 96c23c3 to 2d22daf Compare May 8, 2017 17:01
@bhelx
Copy link
Contributor Author

bhelx commented May 8, 2017

Okay, squashed

@bhelx bhelx merged commit 6501365 into api_version_2_6 May 8, 2017
@aaron-junot aaron-junot deleted the remove_x_records_header_parsing branch September 25, 2018 16:42
@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
@bhelx bhelx mentioned this pull request Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 V2 Client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants