Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the old recurly binary #398

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Remove the old recurly binary #398

merged 1 commit into from
Jul 31, 2018

Conversation

drewish
Copy link
Contributor

@drewish drewish commented Jul 26, 2018

We don't document that the binary is here and we haven't been testing it so I'm going to suggest we remove it and simplify the gem's scope.

@bhelx bhelx self-requested a review July 26, 2018 17:25
bhelx
bhelx approved these changes Jul 31, 2018
View reviewed changes
Copy link
Contributor

@bhelx bhelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bhelx bhelx merged commit 29f5ed1 into master Jul 31, 2018
@bhelx bhelx deleted the drop-bin branch July 31, 2018 16:07
@bhelx bhelx mentioned this pull request Aug 6, 2018
Merged
@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhelx bhelx bhelx approved these changes

Assignees
No one assigned
Labels
V2 V2 Client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drewish @bhelx