fix: Allow Resource to be compare to other object #890
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution, @malbert. Could you fix the issues that this change introduces? You can run the tests locally using the test script: |
lib/recurly/resource.rb
Outdated
| @@ -15,7 +15,8 @@ def requires_client? | |||
| end | |||
|
|
|||
| def ==(other_resource) | |||
| self.attributes == other_resource.attributes | |||
| other.is_a?(Recurly::Resource) && | |||
There was a problem hiding this comment.
The method parameter is other_resource
There was a problem hiding this comment.
Good catch!
Stupid error while renaming variables.
Thank you!
douglasmiller
approved these changes
Apr 2, 2024
recurly-integrations
pushed a commit
that referenced
this pull request
Apr 2, 2024
[Full Changelog](4.48.0...4.48.1) **Merged Pull Requests** - fix: Allow Resource to be compare to other object [#890](#890) ([malbert](https://github.com/malbert))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
Recurly::Resourcedoes not allow to compare to another object that does not respond to theattributesmethod.