Sequential Preflight Calls #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrissrogers
approved these changes
Sep 15, 2022
recurly-integrations
pushed a commit
that referenced
this pull request
Sep 16, 2022
[Full Changelog](v4.22.2...v4.22.3) **Merged Pull Requests** - Sequential Preflight Calls [#749](#749) ([isaacvance1027](https://github.com/isaacvance1027)) ##### Minified MD5 Checksum ``` 5797a937176ff92a2936b378d73c0731 ./build/recurly.min.js ``` ##### [SRI Hash](https://www.srihash.org/) ``` n8svZwDWXMGeDGXKQAkViehxtxB8GtdeAtFj5y15wTt53ZKtj4rSqcseczjLwGYz ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes our processing of the preflights to run authentication calls and device data collection calls in Promises that resolve sequentially instead of all at once in a Promise.all as before.
This is because the event listeners instantiated in risk strategies during this process were previously all receiving the same event since the events do necessarily have unique identifiers.