Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle stripe js error when attaching the stripe element #779

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

cyberxander90
Copy link
Contributor

Description

When attaching the stripe js elements, it may throw depending on the payment intent status.
This PR properly handles the errors to avoid waiting indefinitely for the challenge that will not appear and fail the transaction.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 92.638% when pulling 2500512 on handle-stripe-elements-errors into 6040853 on master.

@chrissrogers chrissrogers merged commit 46daa5b into master Nov 29, 2022
@chrissrogers chrissrogers deleted the handle-stripe-elements-errors branch November 29, 2022 18:40
recurly-integrations pushed a commit that referenced this pull request Nov 30, 2022
[Full Changelog](v4.22.6...v4.22.7)

**Merged Pull Requests**

- Multi form fraud detection [#780](#780) ([smagdicatrecurly](https://github.com/smagdicatrecurly))
- Handle stripe js error when attaching the stripe element [#779](#779) ([cyberxander90](https://github.com/cyberxander90))

##### Minified MD5 Checksum
```
e6ac7ffa0f80194533e2d3a0338ae149 ./build/recurly.min.js
```
##### [SRI Hash](https://www.srihash.org/)
```
tJXv1aA36hSwfXQbG13AXc5o2k0GasDwVREzxWWzyGYKBe0nbQRBx8BD6j+FryhU
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants