fix tax calculations on next object with single-use coupons #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrissrogers
approved these changes
Nov 3, 2023
chrissrogers
approved these changes
Nov 3, 2023
recurly-integrations
pushed a commit
that referenced
this pull request
Nov 3, 2023
[Full Changelog](v4.26.0...v4.26.1) **Merged Pull Requests** - fix tax calculations on next object with single-use coupons [#858](#858) ([wsethbrown](https://github.com/wsethbrown)) ##### Minified MD5 Checksum ``` dbca2bfcf5cbc77760ea23a8920c2246 ./build/recurly.min.js ``` ##### [SRI Hash](https://www.srihash.org/) ``` KHsKcMNzRZu9sJmVX8eA0LOD5rjeIDWkzQeq2c+83MJXr/Zw88BGBrcyIryPu/x5 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When utilizing single-use coupons, the
nextobject in RJS was miscalculating the tax, falling back on thenowobjects subtotal for calculations. This resulted in lower taxes for thenextobject.Gating the logic of the
nextobject'sdiscountAmountbehind whethercoupon.single_useis being used ensures the next object's discount amount applies properly.