Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Amazon Pay should be emitting the 'cancel' event when the window is manually closed #879

Merged
merged 1 commit into from
Apr 8, 2024
Merged

fix: Amazon Pay should be emitting the 'cancel' event when the window is manually closed #879

merged 1 commit into from
Apr 8, 2024

Conversation

douglasmiller
Copy link
Contributor

The AmazonPay window was incorrectly emitting an error event when the user manually closed the recurly window frame. The cancel event should be emitted instead.

@chrissrogers chrissrogers merged commit 80b445c into master Apr 8, 2024
26 checks passed
@chrissrogers chrissrogers deleted the amazon-pay-close-event branch April 8, 2024 18:39
recurly-integrations pushed a commit that referenced this pull request Apr 8, 2024
4.28.1
8412b3b 
[Full Changelog](v4.28.0...v4.28.1)

**Merged Pull Requests**

- fix: Amazon Pay should be emitting the 'cancel' event when the window is manually closed [#879](#879) ([douglasmiller](https://github.com/douglasmiller))

##### Minified MD5 Checksum
```
31e3250f0cd68b5ea0878c1b021fec3f ./build/recurly.min.js
```
##### [SRI Hash](https://www.srihash.org/)
```
2XveJQAN1GxFfJ0Szo30aSQFlziLPJZThv5Gsp5I7PznSLBLHbRHvys8iPi87JT9
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrissrogers chrissrogers chrissrogers approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@douglasmiller @chrissrogers