Add fraud params to Apple-Pay token #915
Open
+14,252
−7,013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsanderson1130
force-pushed
the
add-fraud-params-to-apple-pay-token
branch
5 times, most recently
from
1badb9c to
840de53
Compare
Patrick-Duvall
approved these changes
Feb 28, 2025
jsanderson1130
force-pushed
the
add-fraud-params-to-apple-pay-token
branch
from
4572a05 to
0960bdf
Compare
lib/recurly/apple-pay/apple-pay.js
Outdated
| ...transformAddress(billingContact, { to: 'address', except: ['emailAddress'] }), | ||
| }; | ||
| } | ||
| } | ||
|
|
||
| function combinedInputs () { | ||
| if (this.config.form) { |
There was a problem hiding this comment.
I think it would be appropriate to parameterize this since this function isn't a member of the instance.
function combinedInputs(recurly) {
if (recurly.config.form) {
// ...
There was a problem hiding this comment.
You might want to do an early return for simplification purposes:
if (!this.config.form) {
return;
}
52e2918 to
c79779f
Compare
[Fix] lint error && no fraud object on null [Test] adding tests for apple-pay fraud [TEST] update mocha test for apple-pay fraud [REFACTOR] fix combinedInputs to early return with no config.form [update] remove Electron from unit tests Upgrades e2e visual regression test infrastructure - Updates mobile browser versions - Updates baseline screenshots Removes Electron test structures - Why: complexity in maintenance and comparative Chrome coverage [Fix] fix token js
jsanderson1130
force-pushed
the
add-fraud-params-to-apple-pay-token
branch
from
c79779f to
801a24e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Apple-Pay token params to allow for
fraudparameters.