Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fraud params to Apple-Pay token #915

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jsanderson1130
Copy link
Contributor

Update Apple-Pay token params to allow for fraud parameters.

@jsanderson1130 jsanderson1130 force-pushed the add-fraud-params-to-apple-pay-token branch 5 times, most recently from 1badb9c to 840de53 Compare February 28, 2025 01:50
@jsanderson1130 jsanderson1130 force-pushed the add-fraud-params-to-apple-pay-token branch from 4572a05 to 0960bdf Compare February 28, 2025 20:55
...transformAddress(billingContact, { to: 'address', except: ['emailAddress'] }),
};
}
}

function combinedInputs () {
if (this.config.form) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be appropriate to parameterize this since this function isn't a member of the instance.

function combinedInputs(recurly) {
  if (recurly.config.form) {
  // ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to do an early return for simplification purposes:

if (!this.config.form) {
  return;
}

@jsanderson1130 jsanderson1130 force-pushed the add-fraud-params-to-apple-pay-token branch 4 times, most recently from 52e2918 to c79779f Compare March 3, 2025 23:00
[Fix] lint error && no fraud object on null

[Test] adding tests for apple-pay fraud

[TEST] update mocha test for apple-pay fraud

[REFACTOR] fix combinedInputs to early return with no config.form

[update] remove Electron from unit tests

Upgrades e2e visual regression test infrastructure

- Updates mobile browser versions
- Updates baseline screenshots

Removes Electron test structures

- Why: complexity in maintenance and comparative Chrome coverage

[Fix] fix token js
@jsanderson1130 jsanderson1130 force-pushed the add-fraud-params-to-apple-pay-token branch from c79779f to 801a24e Compare March 5, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants