Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! the font awesome spinner Community uses is 8-fold symmetrical, and has a pretty nice illusion of movement when it's rotated step-wise instead of continuously (which looks kind of strange). This change just means using font awesome's fa-pulse class instead of spin. Cut and dry, except that it also means bumping our font awesome version from 4.2.1 to the latest, 4.6.2*.
Caveat: I'm currently on a train, and can't install all of the dependencies to actually test this. it should just work, but I would really appreciate if someone could check it out and give me a thumbs up 🐑
The difference between spin and pulse is demonstrated here:
http://fontawesome.io/examples/#animated
pulse was introduced in version 4.3.0
FortAwesome/Font-Awesome@89a28f8
*and font awesome follows semver, so this should
theoreticallynot break anything!:https://github.com/FortAwesome/Font-Awesome#versioning
https://rubygems.org/gems/font-awesome-sass/versions
Another solution would be to switch to another spinner that doesn't rely on this illusion, like fa-cog