Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raw_logits in GraphActionCategorical to() method #131

Merged
merged 2 commits into from
May 6, 2024

Conversation

bengioe
Copy link
Collaborator

@bengioe bengioe commented May 2, 2024

raw_logits were not sent to the device, causing downstream errors depending on when the raw logits are used to compute the masked logits.

@bengioe bengioe self-assigned this May 2, 2024
@bengioe
Copy link
Collaborator Author

bengioe commented May 2, 2024

Not sure why the Mac build fails, seems to be some bad config on github's side. Either way this is a minor fix and passes on Linux. Fixed by #132

@bengioe
Copy link
Collaborator Author

bengioe commented May 2, 2024

@julienroyd things seem to work with this fix but I haven't extensively tested. Can you think of other places where we should check for a similar error?

@julienroyd
Copy link
Contributor

@julienroyd things seem to work with this fix but I haven't extensively tested. Can you think of other places where we should check for a similar error?

No, I think it should be good, _masked_logits were already being sent to device so I think raw_logits were the only ones that were left behind.

@bengioe bengioe merged commit 02eaed3 into trunk May 6, 2024
4 checks passed
@bengioe bengioe deleted the emmanuel-device-fix branch May 6, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants