Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try and summarize Open API discussion. #171

Merged
merged 5 commits into from
Dec 12, 2018
Merged

Try and summarize Open API discussion. #171

merged 5 commits into from
Dec 12, 2018

Conversation

fffej
Copy link
Contributor

@fffej fffej commented Dec 11, 2018 •
edited by garethbragg
Loading

Resolves #107

  • Are you happy for the content of this change to be publicly visible?
  • Does radar.csv render correctly when viewed on Github?
  • Does the updated tech radar display as you expect?

tugberkugurlu
tugberkugurlu reviewed Dec 11, 2018
View reviewed changes
radar.csv Outdated Show resolved Hide resolved
@tugberkugurlu @fffej
Apply suggested changes.
5909f48 
Co-Authored-By: fffej <jeff.foster@acm.org>
ChrisHurley
ChrisHurley approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@ChrisHurley ChrisHurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garethbragg
Copy link
Contributor

I hope we don't adopt NSwag, just because it has a stupid name.

@garethbragg garethbragg merged commit 57f09eb into master Dec 12, 2018
@garethbragg garethbragg deleted the open-api branch December 12, 2018 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisHurley ChrisHurley ChrisHurley approved these changes

@tugberkugurlu tugberkugurlu tugberkugurlu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fffej @garethbragg @tugberkugurlu @ChrisHurley